On 25/08/2024 09:52, Philipp Stanner wrote: > Am Donnerstag, dem 22.08.2024 um 13:57 +0100 schrieb Simon Horman: >> This patchset addresses a number of spelling errors in comments in >> Networking files under include/, and files in net/core/. Spelling >> problems are as flagged by codespell. >> >> It aims to provide patches that can be accepted directly into net- >> next. >> And splits patches up based on maintainer boundaries: many things >> feed directly into net-next. This is a complex process and I >> apologise >> for any errors. > > Are you aware that this lessens git blame's ability to provide the > latest relevant change and associated commit message? Considering how many code style changes the kernel receives, I already (and not only me) moved away to just `git log --follow`, so I don't find one more step for `git blame` a problem. > > Many software projects suffer from whitespace and spelling fixes > preventing git blame from figuring out years later what original code > was intended to do. > > I'd consider that improving spelling might not win that cost-benefit- > ratio. I would rather claim that impact on backporting is more important, yet still fixing style makes code more readable thus maintainable. And that's a benefit. Best regards, Krzysztof
