Hi,
On Wed, Aug 14, 2024 at 10:30 AM Alexander Gordeev
<agordeev@xxxxxxxxxxxxx> wrote:
>
> The fixdep binary is being compiled and linked in one step since commit
> ea974028a049 ("tools build: Avoid circular .fixdep-in.o.cmd issues").
> While the host linker flags are passed to the compiler the host compiler
> flags are missed.
>
> That might lead to failures as result of the compiler vs linker flags
> inconsistency. For example, during RPM package build redhat-hardened-ld
> script is provided to gcc, while redhat-hardened-cc1 script is missed.
> That leads to an error on s390:
>
> /usr/bin/ld: /tmp/ccUT8Rdm.o: `stderr@@GLIBC_2.2' non-PLT reloc for
> symbol defined in shared library and accessed from executable (rebuild
> file with -fPIC ?)
>
> Provide both KBUILD_HOSTCFLAGS and KBUILD_HOSTLDFLAGS to avoid that.
>
> Signed-off-by: Alexander Gordeev <agordeev@xxxxxxxxxxxxx>
FWIW, I already fielded some reports about this, and proposed a very
similar (but not identical) fix:
https://lore.kernel.org/lkml/20240814030436.2022155-1-briannorris@xxxxxxxxxxxx/
Frankly, I wasn't sure about HOSTxxFLAGS vs KBUILD_HOSTxxFLAGS -- and
that's the difference between yours and mine. If yours works, that
looks like the cleaner solution. So:
Reviewed-by: Brian Norris <briannorris@xxxxxxxxxxxx>
Either way, it might be good to also include some of these tags if
this is committed:
Closes: https://lore.kernel.org/lkml/99ae0d34-ed76-4ca0-a9fd-c337da33c9f9@xxxxxxxxxxxxx/
Fixes: ea974028a049 ("tools build: Avoid circular .fixdep-in.o.cmd issues")
Brian
