On Tue, Aug 13, 2024 at 07:40:42AM -0700, Jakub Kicinski wrote: > On Tue, 13 Aug 2024 17:55:17 +0800 Wen Gu wrote: > > On 2024/8/13 08:41, Jakub Kicinski wrote: > > > On Wed, 7 Aug 2024 15:59:38 +0800 Wen Gu wrote: > > >> + if (nla_put_u64_64bit(skb, SMC_NLA_LGR_R_SNDBUF_ALLOC, > > >> + lgr->alloc_sndbufs, SMC_NLA_LGR_R_PAD)) > > > > > > nla_put_uint() > > > > Hi, Jakub. Thank you for reminder. > > > > I read the commit log and learned the advantages of this helper. > > But it seems that the support for corresponding user-space helpers > > hasn't kept up yet, e.g. can't find a helper like nla_get_uint in > > latest libnl. > > Add it, then. Danielle added one to libmnl: https://git.netfilter.org/libmnl/commit/?id=102942be401a99943b2c68981b238dadfa788f2d Intention is to use it in ethtool once it appears in a released version of libmnl.
