As the possible failure of the dma_set_max_seg_size(), we should better check the return value of the dma_set_max_seg_size(). Fixes: b0da3498c587 ("PCI: Remove pci_set_dma_max_seg_size()") Signed-off-by: Ma Ke <make24@xxxxxxxxxxx> --- Changes in v2: - modified the patch according to suggestions; - modified Fixes line according to suggestions. --- drivers/s390/net/ism_drv.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/s390/net/ism_drv.c b/drivers/s390/net/ism_drv.c index e36e3ea165d3..54f6638e889c 100644 --- a/drivers/s390/net/ism_drv.c +++ b/drivers/s390/net/ism_drv.c @@ -620,7 +620,10 @@ static int ism_probe(struct pci_dev *pdev, const struct pci_device_id *id) goto err_resource; dma_set_seg_boundary(&pdev->dev, SZ_1M - 1); - dma_set_max_seg_size(&pdev->dev, SZ_1M); + ret = dma_set_max_seg_size(&pdev->dev, SZ_1M); + if (ret) + goto err_resource; + pci_set_master(pdev); ret = ism_dev_init(ism); -- 2.25.1