On Thu, May 02, 2024 at 11:34:24AM GMT, Thomas Huth wrote: > On 02/05/2024 10.56, Andrew Jones wrote: > > On Thu, May 02, 2024 at 10:23:22AM GMT, Thomas Huth wrote: > > > On 01/05/2024 13.29, Nicholas Piggin wrote: > > > > This is based on upstream directly now, not ahead of the powerpc > > > > series. > > > > > > Thanks! ... maybe you could also rebase the powerpc series on this now? (I > > > haven't forgotten about it, just did not find enough spare time for more > > > reviewing yet) > > > > > > > Since v2: > > > > - Rebased to upstream with some patches merged. > > > > - Just a few comment typos and small issues (e.g., quoting > > > > `make shellcheck` in docs) that people picked up from the > > > > last round. > > > > > > When I now run "make shellcheck", I'm still getting an error: > > > > > > In config.mak line 16: > > > AR=ar > > > ^-- SC2209 (warning): Use var=$(command) to assign output (or quote to > > > assign string). > > > > I didn't see this one when testing. I have shellcheck version 0.9.0. > > I'm also using 0.9.0 (from Fedora). Maybe we've got a different default config? Yeah, I tested with AArch64, which sets AR to aarch64-linux-gnu-ar. I just tried x86 and see the warning. > > Anyway, I'm in favor of turning this warning of in the config file, it does > not seem to be really helpful in my eyes. What do you think? I agree. The 2209 description says this warning will only appear for commands that are in a hard coded list, so it's an odd check anyway. Thanks, drew
