On Tue, Apr 30, 2024, at 16:16, Heiko Carstens wrote: > Add missing CONFIG_PM ifdefs to fix this allmodconfig compile error: > > drivers/clk/imx/clk-imx8mp-audiomix.c:356:12: error: > 'clk_imx8mp_audiomix_runtime_suspend' defined but not used > [-Werror=unused-function] > 356 | static int clk_imx8mp_audiomix_runtime_suspend(struct device *dev) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > > Reported-by: Linux Kernel Functional Testing <lkft@xxxxxxxxxx> > Closes: > https://lore.kernel.org/r/CA+G9fYuP7S+a89Ep5g5_Ad69EMwRkJ8nM+MMTzbEcP+6H2oMXQ@xxxxxxxxxxxxxx > Fixes: 1496dd413b2e ("clk: imx: imx8mp: Add pm_runtime support for > power saving") > Signed-off-by: Heiko Carstens <hca@xxxxxxxxxxxxx> Thanks for your patch. I see the bug as well, but I think a better fix is to replace the deprecated SET_RUNTIME_PM_OPS() and SET_NOIRQ_SYSTEM_SLEEP_PM_OPS() with the modern variants, RUNTIME_PM_OPS() and RUNTIME_PM_OPS(). Arnd
