The S/390 architecture doesn't support SMBIOS, so CONFIG_DMI will never be defined there. So we can simply omit these preprocessing directives and speed up the build a bit. Signed-off-by: Jean Delvare <jdelvare@xxxxxxx> Cc: Niklas Schnelle <schnelle@xxxxxxxxxxxxx> Cc: Gerald Schaefer <gerald.schaefer@xxxxxxxxxxxxx> --- Niklas, you added these preprocessing directives as part of commit 81bbf03905aa ("s390/pci: expose a PCI device's UID as its index"). I do not understand the purpose. Am I missing something? arch/s390/pci/pci_sysfs.c | 4 ---- 1 file changed, 4 deletions(-) --- linux-6.8.orig/arch/s390/pci/pci_sysfs.c +++ linux-6.8/arch/s390/pci/pci_sysfs.c @@ -156,7 +156,6 @@ static ssize_t uid_is_unique_show(struct } static DEVICE_ATTR_RO(uid_is_unique); -#ifndef CONFIG_DMI /* analogous to smbios index */ static ssize_t index_show(struct device *dev, struct device_attribute *attr, char *buf) @@ -186,7 +185,6 @@ static struct attribute_group zpci_ident .attrs = zpci_ident_attrs, .is_visible = zpci_index_is_visible, }; -#endif static struct bin_attribute *zpci_bin_attrs[] = { &bin_attr_util_string, @@ -229,8 +227,6 @@ static struct attribute_group pfip_attr_ const struct attribute_group *zpci_attr_groups[] = { &zpci_attr_group, &pfip_attr_group, -#ifndef CONFIG_DMI &zpci_ident_attr_group, -#endif NULL, }; -- Jean Delvare SUSE L3 Support