Re: [kvm-unit-tests RFC 2/2] lib: s390x: css: Name inline assembly arguments and clean them up

[Nico Boehr <nrb@xxxxxxxxxxxxx>]

Quoting Janosch Frank (2024-02-01 15:23:56)
[...]
> diff --git a/lib/s390x/css.h b/lib/s390x/css.h
> index 504b3f14..e4311124 100644
> --- a/lib/s390x/css.h
> +++ b/lib/s390x/css.h
[...]
> @@ -167,11 +167,11 @@ static inline int msch(unsigned long schid, struct schib *addr)
>         int cc;
>  
>         asm volatile(
> -               "       msch    0(%3)\n"
> -               "       ipm     %0\n"
> -               "       srl     %0,28"
> -               : "=d" (cc)
> -               : "d" (reg1), "m" (*addr), "a" (addr)
> +               "       msch    0(%[addr])\n"
> +               "       ipm     %[cc]\n"
> +               "       srl     %[cc],28"
> +               : [cc] "=d" (cc)
> +               : "d" (reg1), [addr] "a" (addr)

I think there was a reason why the "m"(*addr) was here. Either add it back
or add a memory clobber.

I will only take the first patch of this series for now.