On Mon, 2024-04-15 at 16:12 -0700, Kuniyuki Iwashima wrote: > From: Joel Granados via B4 Relay <devnull+j.granados.samsung.com@xxxxxxxxxx> > Date: Fri, 12 Apr 2024 16:48:29 +0200 > > From: Joel Granados <j.granados@xxxxxxxxxxx> > > > > This commit comes at the tail end of a greater effort to remove the > > empty elements at the end of the ctl_table arrays (sentinels) which > > will reduce the overall build time size of the kernel and run time > > memory bloat by ~64 bytes per sentinel (further information Link : > > https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@xxxxxxxxxxxxxxxxxxxxxx/) > > > > * Remove sentinel element from ctl_table structs. > > * Remove extra element in ctl_table arrays declarations > > * Remove instances where an array element is zeroed out to make it look > > like a sentinel. This is not longer needed and is safe after commit > > c899710fe7f9 ("networking: Update to register_net_sysctl_sz") added > > the array size to the ctl_table registration > > * Replace the for loop stop condition that tests for procname == NULL with > > one that depends on array size > > * Removed the "-1" that adjusted for having an extra empty element when > > looping over ctl_table arrays > > * Removing the unprivileged user check in ipv6_route_sysctl_init is > > safe as it is replaced by calling ipv6_route_sysctl_table_size; > > introduced in commit c899710fe7f9 ("networking: Update to > > register_net_sysctl_sz") > > * Replace empty array registration with the register_net_sysctl_sz call. > > > > Signed-off-by: Joel Granados <j.granados@xxxxxxxxxxx> > > --- > > net/core/neighbour.c | 5 +---- > > net/core/sysctl_net_core.c | 9 ++++----- > > net/dccp/sysctl.c | 2 -- > > net/ieee802154/6lowpan/reassembly.c | 6 +----- > > net/ipv4/devinet.c | 5 ++--- > > net/ipv4/ip_fragment.c | 2 -- > > net/ipv4/route.c | 8 ++------ > > net/ipv4/sysctl_net_ipv4.c | 7 +++---- > > net/ipv4/xfrm4_policy.c | 1 - > > net/ipv6/addrconf.c | 5 +---- > > net/ipv6/icmp.c | 1 - > > net/ipv6/reassembly.c | 2 -- > > net/ipv6/route.c | 5 ----- > > net/ipv6/sysctl_net_ipv6.c | 4 +--- > > net/ipv6/xfrm6_policy.c | 1 - > > net/llc/sysctl_net_llc.c | 8 ++------ > > net/mpls/af_mpls.c | 3 +-- > > net/mptcp/ctrl.c | 1 - > > net/netrom/sysctl_net_netrom.c | 1 - > > net/phonet/sysctl.c | 1 - > > net/rds/ib_sysctl.c | 1 - > > net/rds/sysctl.c | 1 - > > net/rds/tcp.c | 1 - > > net/rose/sysctl_net_rose.c | 1 - > > net/rxrpc/sysctl.c | 1 - > > net/sctp/sysctl.c | 6 +----- > > net/smc/smc_sysctl.c | 1 - > > net/sunrpc/sysctl.c | 1 - > > net/sunrpc/xprtrdma/svc_rdma.c | 1 - > > net/sunrpc/xprtrdma/transport.c | 1 - > > net/sunrpc/xprtsock.c | 1 - > > net/tipc/sysctl.c | 1 - > > net/unix/sysctl_net_unix.c | 1 - > > net/x25/sysctl_net_x25.c | 1 - > > net/xfrm/xfrm_sysctl.c | 5 +---- > > 35 files changed, 20 insertions(+), 81 deletions(-) > > You may want to split patch based on subsystem or the type of changes > to make review easier. I agree with Kuniyuki. I think the x25 chunks can me moved in the last patch, and at least sunrpc and rds could go in separate patches, possibly even xfrm and smc. Thanks, Paolo
