On Thu, 2024-04-11 at 09:16 +0200, Paolo Abeni wrote: > Hi, > > On Tue, 2024-04-09 at 13:37 +0200, Gerd Bayer wrote: > > This reverts commit 58effa3476536215530c9ec4910ffc981613b413. > > Review was not finished on this patch. So it's not ready for > > upstreaming. > > > > Signed-off-by: Gerd Bayer <gbayer@xxxxxxxxxxxxx> > > It's not a big deal (no need to repost), but should the need arise > again in the future it would be better explicitly marking the > reverted commit in the tag area as 'Fixes'. The full hash in the > commit message will likely save the day to stable teams, but better > safe then sorry! Thanks Paolo for the explanation. I was not even sure if the commit hash of the erroneous commit will remain stable when this tree will be merged upstream. In my (naive?) view this could be "autosquashed" into nothing at the time of the merge. But since there appears to be time for the next pull request to upstream, I'll send a new version of the original patch with all the review comments addressed. Thanks again, Gerd
