From: Yury Norov <yury.norov@xxxxxxxxx> Date: Wed, 28 Feb 2024 08:38:49 -0800 > On Thu, Feb 01, 2024 at 01:22:12PM +0100, Alexander Lobakin wrote: >> Now that there are helpers for converting IP tunnel flags between the >> old __be16 format and the bitmap format, make sure they work as expected >> by adding a couple of tests to the bitmap testing suite. The helpers are >> all inline, so no dependencies on the related CONFIG_* (or a standalone >> module) are needed. >> >> Cover three possible cases: >> >> 1. No bits past BIT(15) are set, VTI/SIT bits are not set. This >> conversion is almost a direct assignment. >> 2. No bits past BIT(15) are set, but VTI/SIT bit is set. During the >> conversion, it must be transformed into BIT(16) in the bitmap, >> but still compatible with the __be16 format. >> 3. The bitmap has bits past BIT(15) set (not the VTI/SIT one). The >> result will be truncated. >> Note that currently __IP_TUNNEL_FLAG_NUM is 17 (incl. special), >> which means that the result of this case is currently >> semi-false-positive. When BIT(17) is finally here, it will be >> adjusted accordingly. >> >> Signed-off-by: Alexander Lobakin <aleksander.lobakin@xxxxxxxxx> > > So why testing IP tunnels stuff in lib/test_bitmap? I think it should > go with the rest of networking code. When I was creating these tests, there was no networking-specific KUnit, but now we have one, so it makes sense to move it. Thanks, Olek
