On Thu, Mar 14, 2024 at 05:52:09PM +0800, Li Zhijian wrote: > Per filesystems/sysfs.rst, show() should only use sysfs_emit() > or sysfs_emit_at() when formatting the value to be returned to user space. > > coccinelle complains that there are still a couple of functions that use > snprintf(). Convert them to sysfs_emit(). > > sprintf() will be converted as weel if they have. > > Generally, this patch is generated by > make coccicheck M=<path/to/file> MODE=patch \ > COCCI=scripts/coccinelle/api/device_attr_show.cocci > > No functional change intended > > CC: Vineeth Vijayan <vneethv@xxxxxxxxxxxxx> > CC: Peter Oberparleiter <oberpar@xxxxxxxxxxxxx> > CC: Heiko Carstens <hca@xxxxxxxxxxxxx> > CC: Vasily Gorbik <gor@xxxxxxxxxxxxx> > CC: Alexander Gordeev <agordeev@xxxxxxxxxxxxx> > CC: Christian Borntraeger <borntraeger@xxxxxxxxxxxxx> > CC: Sven Schnelle <svens@xxxxxxxxxxxxx> > CC: linux-s390@xxxxxxxxxxxxxxx > Signed-off-by: Li Zhijian <lizhijian@xxxxxxxxxxx> > --- > This is a part of the work "Fix coccicheck device_attr_show warnings"[1] > Split them per subsystem so that the maintainer can review it easily > [1] https://lore.kernel.org/lkml/20240116041129.3937800-1-lizhijian@xxxxxxxxxxx/ > --- > drivers/s390/cio/css.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) Applied, but... > @@ -396,7 +396,7 @@ static ssize_t pimpampom_show(struct device *dev, > struct subchannel *sch = to_subchannel(dev); > struct pmcw *pmcw = &sch->schib.pmcw; > > - return sprintf(buf, "%02x %02x %02x\n", > + return sysfs_emit(buf, "%02x %02x %02x\n", > pmcw->pim, pmcw->pam, pmcw->pom); ...please make sure to fix such whitespace / indentation errors if you plan to provide more patches. I fixed it this time. Thanks!
