Re: [kvm-unit-tests PATCH] (arm|powerpc|s390x): Makefile: add `%.aux.o` target

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 25/01/2024 16.11, Marc Hartmayer wrote:
It's unusual to create multiple files in one target rule, therefore create an
extra target for `%.aux.o` and list it as prerequisite. As a side effect, this
change fixes the dependency tracking of the prerequisites of
`.aux.o` (`lib/auxinfo.c` was missing).

Signed-off-by: Marc Hartmayer <mhartmay@xxxxxxxxxxxxx>
---
  arm/Makefile.common     | 23 ++++++++++++-----------
  powerpc/Makefile.common | 10 +++++-----
  s390x/Makefile          |  9 +++++----
  3 files changed, 22 insertions(+), 20 deletions(-)

Patch looks sane to me, so I went ahead and pushed it to the git repo. Thanks!

By the way, unrelated to your modifications, but while testing it, I noticed that "make distclean" leaves some files behind for the s390x build:

 ./configure --arch=s390x --cross-prefix=s390x-linux-gnu-
 make -j$(nproc)
 make distclean
 git status --ignored

On branch master
Your branch is up to date with 'origin/master'.

Ignored files:
  (use "git add -f <file>..." to include in what will be committed)
	.mvpg-snippet.d
	.sie-dat.d
	.spec_ex.d
	lib/auxinfo.o
	s390x/snippets/c/.cstart.d
	s390x/snippets/c/.flat.d

... in case someone wants to have a look ...

 Thomas





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Kernel Development]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Info]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Linux Media]     [Device Mapper]

  Powered by Linux