On Sun, Jan 28, 2024 at 08:58:53PM +0100, Alexander Gordeev wrote: > update_timer_sys() and update_timer_mcck() are inlines used for > CPU time accounting from the interrupt and machine-check handlers. > These routines are specific to s390 architecture, but declared > via <linux/vtime.h> header, which in turn inludes <asm/vtime.h>. > Avoid the extra loop and include <asm/vtime.h> header directly. > > Signed-off-by: Alexander Gordeev <agordeev@xxxxxxxxxxxxx> > --- > arch/s390/kernel/irq.c | 1 + > arch/s390/kernel/nmi.c | 1 + > 2 files changed, 2 insertions(+) ... > +++ b/arch/s390/kernel/irq.c > +#include <asm/vtime.h> ... > +++ b/arch/s390/kernel/nmi.c > +#include <asm/vtime.h> It is confusing when the patch subject is "do not include.." and all what this patch is doing is to add two includes. I see what this is doing: getting rid of the implicit include of asm/vtime.h most likely via linux/hardirq.h, but that's not very obvious. Anyway: Acked-by: Heiko Carstens <hca@xxxxxxxxxxxxx>
