On 01/25/24 at 09:55pm, Nathan Chancellor wrote: ...... > I am seeing a few build failures in my test matrix on next-20240125 that > appear to be caused by this series although I have not bisected. Some > reproduction steps: Thanks for trying this, I have reproduced the linking failure on arm, will work out a way to fix it. It's weird, I remember I have built these and passed. > > $ curl -LSso .config https://git.alpinelinux.org/aports/plain/community/linux-edge/config-edge.armv7 > $ make -skj"$(nproc)" ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- olddefconfig all > ... > arm-linux-gnueabi-ld: arch/arm/kernel/machine_kexec.o: in function `arch_crash_save_vmcoreinfo': > machine_kexec.c:(.text+0x488): undefined reference to `vmcoreinfo_append_str' > ... > > $ curl -LSso .config https://github.com/archlinuxarm/PKGBUILDs/raw/master/core/linux-aarch64/config > $ make -skj"$(nproc)" ARCH=arm64 CROSS_COMPILE=aarch64-linux- olddefconfig all > ... > aarch64-linux-ld: kernel/kexec_file.o: in function `kexec_walk_memblock.constprop.0': > kexec_file.c:(.text+0x314): undefined reference to `crashk_res' > aarch64-linux-ld: kernel/kexec_file.o: relocation R_AARCH64_ADR_PREL_PG_HI21 against symbol `crashk_res' which may bind externally can not be used when making a shared object; recompile with -fPIC > kexec_file.c:(.text+0x314): dangerous relocation: unsupported relocation > aarch64-linux-ld: kexec_file.c:(.text+0x318): undefined reference to `crashk_res' > aarch64-linux-ld: drivers/of/kexec.o: in function `of_kexec_alloc_and_setup_fdt': > kexec.c:(.text+0x580): undefined reference to `crashk_res' > aarch64-linux-ld: drivers/of/kexec.o: relocation R_AARCH64_ADR_PREL_PG_HI21 against symbol `crashk_res' which may bind externally can not be used when making a shared object; recompile with -fPIC > kexec.c:(.text+0x580): dangerous relocation: unsupported relocation > aarch64-linux-ld: kexec.c:(.text+0x584): undefined reference to `crashk_res' > aarch64-linux-ld: kexec.c:(.text+0x590): undefined reference to `crashk_res' > aarch64-linux-ld: kexec.c:(.text+0x5b0): undefined reference to `crashk_low_res' > aarch64-linux-ld: drivers/of/kexec.o: relocation R_AARCH64_ADR_PREL_PG_HI21 against symbol `crashk_low_res' which may bind externally can not be used when making a shared object; recompile with -fPIC > kexec.c:(.text+0x5b0): dangerous relocation: unsupported relocation > aarch64-linux-ld: kexec.c:(.text+0x5b4): undefined reference to `crashk_low_res' > aarch64-linux-ld: kexec.c:(.text+0x5c0): undefined reference to `crashk_low_res' > ... > > $ curl -LSso .config https://git.alpinelinux.org/aports/plain/community/linux-edge/config-edge.x86_64 > $ make -skj"$(nproc)" ARCH=x86_64 CROSS_COMPILE=x86_64-linux- olddefconfig all > ... > x86_64-linux-ld: arch/x86/xen/mmu_pv.o: in function `paddr_vmcoreinfo_note': > mmu_pv.c:(.text+0x3af3): undefined reference to `vmcoreinfo_note' > ... > > Cheers, > Nathan >