Re: [PATCH net-next v6 02/10] net/smc: introduce sub-functions for smc_clc_send_confirm_accept()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Wen Gu <guwen@xxxxxxxxxxxxxxxxx>, wenjia@xxxxxxxxxxxxx, hca@xxxxxxxxxxxxx, gor@xxxxxxxxxxxxx, agordeev@xxxxxxxxxxxxx, davem@xxxxxxxxxxxxx, edumazet@xxxxxxxxxx, kuba@xxxxxxxxxx, pabeni@xxxxxxxxxx, kgraul@xxxxxxxxxxxxx, jaka@xxxxxxxxxxxxx
Subject: Re: [PATCH net-next v6 02/10] net/smc: introduce sub-functions for smc_clc_send_confirm_accept()
From: Alexandra Winter <wintera@xxxxxxxxxxxxx>
Date: Mon, 18 Dec 2023 09:41:31 +0100
Cc: borntraeger@xxxxxxxxxxxxx, svens@xxxxxxxxxxxxx, alibuda@xxxxxxxxxxxxxxxxx, tonylu@xxxxxxxxxxxxxxxxx, raspl@xxxxxxxxxxxxx, schnelle@xxxxxxxxxxxxx, guangguan.wang@xxxxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <1702371151-125258-3-git-send-email-guwen@linux.alibaba.com>
References: <1702371151-125258-1-git-send-email-guwen@linux.alibaba.com> <1702371151-125258-3-git-send-email-guwen@linux.alibaba.com>
User-agent: Mozilla Thunderbird


On 12.12.23 09:52, Wen Gu wrote:
> There is a large if-else block in smc_clc_send_confirm_accept() and it
> is better to split it into two sub-functions.
> 
> Suggested-by: Alexandra Winter <wintera@xxxxxxxxxxxxx>
> Signed-off-by: Wen Gu <guwen@xxxxxxxxxxxxxxxxx>
> ---

Reviewed-by: Alexandra Winter <wintera@xxxxxxxxxxxxx>

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

References:
- [PATCH net-next v6 00/10] net/smc: implement SMCv2.1 virtual ISM device support
  - From: Wen Gu
- [PATCH net-next v6 02/10] net/smc: introduce sub-functions for smc_clc_send_confirm_accept()
  - From: Wen Gu

Prev by Date: Re: [PATCH net-next v6 03/10] net/smc: unify the structs of accept or confirm message for v1 and v2
Next by Date: selftests/livepatch fails on s390
Previous by thread: [PATCH net-next v6 02/10] net/smc: introduce sub-functions for smc_clc_send_confirm_accept()
Next by thread: [PATCH net-next v6 03/10] net/smc: unify the structs of accept or confirm message for v1 and v2
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite Info] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Samba] [Linux Media] [Device Mapper]