On Thu, Nov 23, 2023 at 03:36:51PM +0800, Baoquan He wrote: > When below kernel config items are set, compiling error are triggered. > > CONFIG_CRASH_CORE=y > CONFIG_KEXEC_CORE=y > CONFIG_CRASH_DUMP=y > CONFIG_CRASH_HOTPLUG=y > > ------------------------------------------------------ > drivers/base/cpu.c: In function ‘crash_hotplug_show’: > drivers/base/cpu.c:309:40: error: implicit declaration of function ‘crash_hotplug_cpu_support’; did you mean ‘crash_hotplug_show’? [-Werror=implicit-function-declaration] > 309 | return sysfs_emit(buf, "%d\n", crash_hotplug_cpu_support()); > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > | crash_hotplug_show > cc1: some warnings being treated as errors > ------------------------------------------------------ > > CONFIG_KEXEC is used to enable kexec_load interface, the > crash_notes/crash_notes_size/crash_hotplug showing depends on > CONFIG_KEXEC is incorrect. It should depend on KEXEC_CORE instead. > > Fix it now. If this error introduced with the prevous patch? If so, the patches need to be swapped I guess. > Signed-off-by: Baoquan He <bhe@xxxxxxxxxx>
