Re: [PATCH 3/8] mm: use vmem_altmap code without CONFIG_ZONE_DEVICE

To: Sumanth Korikkar <sumanthk@xxxxxxxxxxxxx>, linux-mm <linux-mm@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 3/8] mm: use vmem_altmap code without CONFIG_ZONE_DEVICE
From: David Hildenbrand <david@xxxxxxxxxx>
Date: Thu, 16 Nov 2023 19:43:00 +0100
Cc: Oscar Salvador <osalvador@xxxxxxx>, Michal Hocko <mhocko@xxxxxxxx>, "Aneesh Kumar K.V" <aneesh.kumar@xxxxxxxxxxxxx>, Anshuman Khandual <anshuman.khandual@xxxxxxx>, Gerald Schaefer <gerald.schaefer@xxxxxxxxxxxxx>, Alexander Gordeev <agordeev@xxxxxxxxxxxxx>, Heiko Carstens <hca@xxxxxxxxxxxxx>, Vasily Gorbik <gor@xxxxxxxxxxxxx>, linux-s390 <linux-s390@xxxxxxxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <20231114180238.1522782-4-sumanthk@linux.ibm.com>
Organization: Red Hat
References: <20231114180238.1522782-1-sumanthk@linux.ibm.com> <20231114180238.1522782-4-sumanthk@linux.ibm.com>
User-agent: Mozilla Thunderbird

On 14.11.23 19:02, Sumanth Korikkar wrote:

vmem_altmap_free() and vmem_altmap_offset() could be utlized without
CONFIG_ZONE_DEVICE enabled. Hence, move it to sparse-vmemmap.c

Maybe give an example: For example mm/memory_hotplug.c:__add_pages()relies on that.


The altmap is no longer restricted to ZONE_DEVICE handling.

Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>

--
Cheers,

David / dhildenb

References:
- [PATCH 0/8] implement "memmap on memory" feature on s390
  - From: Sumanth Korikkar
- [PATCH 3/8] mm: use vmem_altmap code without CONFIG_ZONE_DEVICE
  - From: Sumanth Korikkar