> -----Original Message----- > From: Wen Gu <guwen@xxxxxxxxxxxxxxxxx> > Sent: Thursday, November 16, 2023 5:28 PM > To: Li,Rongqing <lirongqing@xxxxxxxxx>; wenjia@xxxxxxxxxxxx; > netdev@xxxxxxxxxxxxxxx; linux-s390@xxxxxxxxxxxxxxx; dust.li@xxxxxxxxxxxxxxxxx > Subject: Re: [PATCH][net-next] net/smc: avoid atomic_set and smp_wmb in the > tx path when possible > > > > On 2023/11/16 10:20, Li RongQing wrote: > > there is rare possibility that conn->tx_pushing is not 1, since > There > > tx_pushing is just checked with 1, so move the setting tx_pushing to 1 > > after atomic_dec_and_test() return false, to avoid atomic_set and > > smp_wmb in tx path > . > > > > Some nits: > > 1. It is normally using [PATCH net-next] rather than [PATCH][net-next] > in subject. And new version should better be marked. such as: > > # git format-patch --subject-prefix="PATCH net-next" -v 3 > > And CC all relevant people listed by: > > # ./scripts/get_maintainer.pl <your patch> > > 2. Few improvements in the commit body. > > Ok, thanks -Li
