> -----Original Message----- > From: Dust Li <dust.li@xxxxxxxxxxxxxxxxx> > Sent: Thursday, November 2, 2023 10:54 PM > To: Li,Rongqing <lirongqing@xxxxxxxxx>; linux-s390@xxxxxxxxxxxxxxx; > netdev@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] net/smc: avoid atomic_set and smp_wmb in the tx path > when possible > > On Thu, Nov 02, 2023 at 05:27:12PM +0800, Li RongQing wrote: > >these is less opportunity that conn->tx_pushing is not 1, since > > these -> there ? Yes, thanks > > >tx_pushing is just checked with 1, so move the setting tx_pushing to 1 > >after atomic_dec_and_test() return false, to avoid atomic_set and > >smp_wmb in tx path when possible > > The patch should add [PATCH net-next] subject-prefix since this is an > optimization. > OK > Besides, do you have any performance number ? Just try a simple performance test, seems same. -Li
