Re: [PATCH net v1 1/3] net/smc: fix dangling sock under state SMC_APPFINCLOSEWAIT

["D. Wythe" <alibuda@xxxxxxxxxxxxxxxxx>]

On 11/2/23 6:34 PM, Wenjia Zhang wrote:
> On 02.11.23 06:52, D. Wythe wrote:
> > From: "D. Wythe" <alibuda@xxxxxxxxxxxxxxxxx>
> >
> > Considering scenario:
> >
> >                 smc_cdc_rx_handler
> > __smc_release
> >                 sock_set_flag
> > smc_close_active()
> > sock_set_flag
> >
> > __set_bit(DEAD)            __set_bit(DONE)
> >
> > Dues to __set_bit is not atomic, the DEAD or DONE might be lost.
> > if the DEAD flag lost, the state SMC_CLOSED  will be never be reached
> > in smc_close_passive_work:
> >
> > if (sock_flag(sk, SOCK_DEAD) &&
> >     smc_close_sent_any_close(conn)) {
> >     sk->sk_state = SMC_CLOSED;
> > } else {
> >     /* just shutdown, but not yet closed locally */
> >     sk->sk_state = SMC_APPFINCLOSEWAIT;
> > }
> >
> > Replace sock_set_flags or __set_bit to set_bit will fix this problem.
> > Since set_bit is atomic.
> >
> > Signed-off-by: D. Wythe <alibuda@xxxxxxxxxxxxxxxxx>
> > Reviewed-by: Dust Li <dust.li@xxxxxxxxxxxxxxxxx>
>
> Fixes tag?

ops, i forget that. 🙁
I will fix it in next version.

Thanks.
D. Wythe