On 10/20/23 16:48, Nina Schoetterl-Glausch wrote:
Rewrite recursion with separate functions for checking containers, containers containing CPUs and CPUs. This improves comprehension and allows for more tests. We now also test for ordering of CPU TLEs and number of child entries. Signed-off-by: Nina Schoetterl-Glausch <nsg@xxxxxxxxxxxxx>
So, I've spent some time with the STSI specification and most of what I've read makes sense, the other parts likely need more research on my end. Anyway:
Acked-by: Janosch Frank <frankja@xxxxxxxxxxxxx>
--- lib/s390x/stsi.h | 36 +++++---- s390x/topology.c | 201 ++++++++++++++++++++++++++++------------------- 2 files changed, 142 insertions(+), 95 deletions(-) diff --git a/lib/s390x/stsi.h b/lib/s390x/stsi.h index 1e9d0958..f2290ca7 100644 --- a/lib/s390x/stsi.h +++ b/lib/s390x/stsi.h
[...]
#define CPU_TOPOLOGY_MAX_LEVEL 6 diff --git a/s390x/topology.c b/s390x/topology.c index df158aef..037d22cd 100644 --- a/s390x/topology.c +++ b/s390x/topology.c @@ -2,7 +2,7 @@ /* * CPU Topology * - * Copyright IBM Corp. 2022 + * Copyright IBM Corp. 2022, 2023 * * Authors: * Pierre Morel <pmorel@xxxxxxxxxxxxx>
If you touch this anyway, it might make sense to add your name to the authors :)
