On 24.09.23 17:16, Wen Gu wrote: > This patch implements GID/CHID/SEID related operations of SMC-D loopback device. In loopback device, GID is generated by UUIDv4 algorithm, CHID is reserved 0xFFFF, SEID is generated using the same algorithm as ISM device under s390 architecture, and is 0 and disabled under non-s390 architecture. Signed-off-by: Wen Gu <guwen@xxxxxxxxxxxxxxxxx> --- IMO, get_system_eid should not be part of smcd_ops. And should not be provided by an smcd device. It is a system_eid is a global value that is valid for all smcd interfaces of this system (os instance). So I think it should be provided by the smc module. I agree it needs to be architecture dependent and same as today for s390.
