On 24.09.23 17:16, Wen Gu wrote: > This patch set includes 4 parts: > > - Patch #1-#3: decouple ISM device hard code from SMC-D stack. > - Patch #4-#8: implement virtual ISM extension defined in SMCv2.1. > - Patch #9-#13: implement loopback-ism device. > - Patch #14-#18: memory copy optimization for the case using loopback. Your cover letter is very well helpful, thanks a lot for that. I really like the way you grouped the patches. Just a thought: If it takes too long to get this large patchset reviewed, you could split it up into smaller sets and get them upstream one after the other. I think it is especially valuable to more crisply define the interface between SMC-D and the smc-d devices, given that virtio-ism may soon be a third kind of smcd device.