Re: [kvm-unit-tests PATCH v1] s390x: explicitly mark stack as not executable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Thomas Huth (2023-08-13 11:50:00)
> On 09/08/2023 11.17, Nico Boehr wrote:
> > With somewhat recent GCC versions, we get this warning on s390x:
> > 
> >    /usr/bin/ld: warning: s390x/cpu.o: missing .note.GNU-stack section implies executable stack
> >    /usr/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
> > 
> > We don't really care whether stack is executable or not since we set it
> > up ourselves and we're running DAT off mostly anyways.
> > 
> > Silence the warning by explicitly marking the stack as not executable.
> > 
> > Signed-off-by: Nico Boehr <nrb@xxxxxxxxxxxxx>
> > ---
> >   s390x/Makefile | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/s390x/Makefile b/s390x/Makefile
> > index 706be7920406..afa47ccbeb93 100644
> > --- a/s390x/Makefile
> > +++ b/s390x/Makefile
> > @@ -79,7 +79,7 @@ CFLAGS += -O2
> >   CFLAGS += -march=zEC12
> >   CFLAGS += -mbackchain
> >   CFLAGS += -fno-delete-null-pointer-checks
> > -LDFLAGS += -nostdlib -Wl,--build-id=none
> > +LDFLAGS += -nostdlib -Wl,--build-id=none -z noexecstack
> 
> I already did a similar patch some weeks ago:
> 
>   https://lore.kernel.org/kvm/20230623125416.481755-1-thuth@xxxxxxxxxx/
> 
> ... we need it for x86, too, so I guess I should go ahead and commit it - 
> and ask Sean to respin his conflicting series.

Thanks!




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Kernel Development]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Info]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Linux Media]     [Device Mapper]

  Powered by Linux