On Tue, 2023-08-15 at 16:08 +0800, Li Zetao wrote: > Use the builtin_misc_device macro to simplify the code, which is the same > as declaring with device_initcall(). > > Signed-off-by: Li Zetao <lizetao1@xxxxxxxxxx> > --- > arch/s390/pci/pci_clp.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/arch/s390/pci/pci_clp.c b/arch/s390/pci/pci_clp.c > index ee367798e388..ee90a91ed888 100644 > --- a/arch/s390/pci/pci_clp.c > +++ b/arch/s390/pci/pci_clp.c > @@ -666,9 +666,4 @@ static struct miscdevice clp_misc_device = { > .fops = &clp_misc_fops, > }; > > -static int __init clp_misc_init(void) > -{ > - return misc_register(&clp_misc_device); > -} > - > -device_initcall(clp_misc_init); > +builtin_misc_device(clp_misc_device); Thanks, makes sense to me. Acked-by: Niklas Schnelle <schnelle@xxxxxxxxxxxxx>