Re: [PATCH 02/17] [RESEND] irq_work: consolidate arch_irq_work_raise prototypes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "Masahiro Yamada" <masahiroy@xxxxxxxxxx>, "Arnd Bergmann" <arnd@xxxxxxxxxx>
Subject: Re: [PATCH 02/17] [RESEND] irq_work: consolidate arch_irq_work_raise prototypes
From: "Arnd Bergmann" <arnd@xxxxxxxx>
Date: Sat, 12 Aug 2023 09:34:34 +0200
Cc: "Andrew Morton" <akpm@xxxxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, "Catalin Marinas" <catalin.marinas@xxxxxxx>, "Palmer Dabbelt" <palmer@xxxxxxxxxxxx>, guoren <guoren@xxxxxxxxxx>, "Alexander Gordeev" <agordeev@xxxxxxxxxxxxx>, "Russell King" <linux@xxxxxxxxxxxxxxx>, "Will Deacon" <will@xxxxxxxxxx>, "Michael Ellerman" <mpe@xxxxxxxxxxxxxx>, "Nicholas Piggin" <npiggin@xxxxxxxxx>, "Christophe Leroy" <christophe.leroy@xxxxxxxxxx>, "Paul Walmsley" <paul.walmsley@xxxxxxxxxx>, "Palmer Dabbelt" <palmer@xxxxxxxxxxx>, "Albert Ou" <aou@xxxxxxxxxxxxxxxxx>, "Heiko Carstens" <hca@xxxxxxxxxxxxx>, "Vasily Gorbik" <gor@xxxxxxxxxxxxx>, "Christian Borntraeger" <borntraeger@xxxxxxxxxxxxx>, "Sven Schnelle" <svens@xxxxxxxxxxxxx>, "Thomas Gleixner" <tglx@xxxxxxxxxxxxx>, "Ingo Molnar" <mingo@xxxxxxxxxx>, "Borislav Petkov" <bp@xxxxxxxxx>, "Dave Hansen" <dave.hansen@xxxxxxxxxxxxxxx>, x86@xxxxxxxxxx, "H. Peter Anvin" <hpa@xxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, "linux-csky@xxxxxxxxxxxxxxx" <linux-csky@xxxxxxxxxxxxxxx>, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx
Feedback-id: i56a14606:Fastmail
In-reply-to: <CAK7LNAQo5hri-9JmS_kot1mQ6WHCWAeu+SnW19daWMC1YK5BWA@mail.gmail.com>
References: <20230810141947.1236730-1-arnd@kernel.org> <20230810141947.1236730-3-arnd@kernel.org> <CAK7LNAQo5hri-9JmS_kot1mQ6WHCWAeu+SnW19daWMC1YK5BWA@mail.gmail.com>
User-agent: Cyrus-JMAP/3.9.0-alpha0-624-g7714e4406d-fm-20230801.001-g7714e440

On Sat, Aug 12, 2023, at 00:10, Masahiro Yamada wrote:
> On Fri, Aug 11, 2023 at 10:00 AM Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
>>
>> From: Arnd Bergmann <arnd@xxxxxxxx>
>>
>> The prototype was hidden on x86, which causes a warning:
>
>
> What do you mean by "hidden on x86"?
>
> arch_irq_work_raise() was declared on 7 architectures,
> including x86.
>

I meant hidden in some configurations. Specifically, x86
only declares the function when it overrides it for
CONFIG_X86_LOCAL_APIC, while without that option the generic
stub still gets compiled but is never declared.

    Arnd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

References:
- [PATCH 00/17] -Wmissing-prototype warning fixes
  - From: Arnd Bergmann
- [PATCH 02/17] [RESEND] irq_work: consolidate arch_irq_work_raise prototypes
  - From: Arnd Bergmann
- Re: [PATCH 02/17] [RESEND] irq_work: consolidate arch_irq_work_raise prototypes
  - From: Masahiro Yamada

Prev by Date: Re: [PATCH v6 15/25] iommufd/selftest: Make the mock iommu driver into a real driver
Next by Date: Re: [PATCH 13/17] block: consolidate __invalidate_device and fsync_bdev
Previous by thread: Re: [PATCH 02/17] [RESEND] irq_work: consolidate arch_irq_work_raise prototypes
Next by thread: [PATCH 14/17] kprobes: unify kprobes_exceptions_nofify() prototypes
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite Info] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Samba] [Linux Media] [Device Mapper]