Re: [PATCH -next] s390: remove unnecessary dev_set_drvdata()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 08, 2023 at 08:55:01PM +0800, Yang Yingliang wrote:
> The driver data will be cleared in device_unbind_cleanup() in driver
> core code. So the dev_set_drvdata(..., NULL) called in remove and
> error path in probe can be removed.
> 
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> ---
>  drivers/s390/block/scm_drv.c      | 2 --
>  drivers/s390/char/con3215.c       | 1 -
>  drivers/s390/char/tape_core.c     | 1 -
>  drivers/s390/cio/chsc_sch.c       | 2 --
>  drivers/s390/cio/vfio_ccw_drv.c   | 2 --
>  drivers/s390/crypto/vfio_ap_ops.c | 1 -
>  6 files changed, 9 deletions(-)

And now you expect us to review six drivers if this trivial change may
or may not introduce subtle bugs?

This is not going to happen, unless there is a really good reason why
this patch makes sense besides some cleanup.



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Kernel Development]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Info]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Linux Media]     [Device Mapper]

  Powered by Linux