On Mon, Aug 07, 2023 at 02:27:19PM +0800, Guangguan Wang wrote:
...
> diff --git a/net/smc/smc_llc.c b/net/smc/smc_llc.c
...
> @@ -1414,6 +1420,9 @@ int smc_llc_srv_add_link(struct smc_link *link,
> goto out;
> }
>
> + if (lgr->type == SMC_LGR_SINGLE && lgr->max_links <= 1)
Hi Guangguan Wang,
The function will return rc.
Should it be set to an error value here?
Flagged by Smatch.
> + goto out;
> +
> /* ignore client add link recommendation, start new flow */
> ini->vlan_id = lgr->vlan_id;
> if (lgr->smc_version == SMC_V2) {
> --
> 2.24.3 (Apple Git-128)
>
