Re: [PATCH v2 2/2] KVM: s390: add tracepoint in gmap notifier

To: Nico Boehr <nrb@xxxxxxxxxxxxx>, borntraeger@xxxxxxxxxxxxx, frankja@xxxxxxxxxxxxx, imbrenda@xxxxxxxxxxxxx
Subject: Re: [PATCH v2 2/2] KVM: s390: add tracepoint in gmap notifier
From: David Hildenbrand <david@xxxxxxxxxx>
Date: Fri, 4 Aug 2023 11:59:22 +0200
Cc: kvm@xxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx
In-reply-to: <169114236545.36389.12085901437050856794@t14-nrb>
Organization: Red Hat
References: <20230510121822.546629-1-nrb@linux.ibm.com> <20230510121822.546629-3-nrb@linux.ibm.com> <6f8951e2-9ea6-5bad-9c2c-b27d70d57ffe@redhat.com> <169114236545.36389.12085901437050856794@t14-nrb>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0

#endif /* _TRACE_KVMS390_H */


In the context of vsie, I'd have thought you'd be tracing
kvm_s390_vsie_gmap_notifier() instead.


Right, I can change that if you / others have a preference for that.


No strong opinion, just a thought.


--
Cheers,

David / dhildenb

References:
- [PATCH v2 0/2] KVM: s390: add counters for vsie performance
  - From: Nico Boehr
- [PATCH v2 2/2] KVM: s390: add tracepoint in gmap notifier
  - From: Nico Boehr
- Re: [PATCH v2 2/2] KVM: s390: add tracepoint in gmap notifier
  - From: David Hildenbrand
- Re: [PATCH v2 2/2] KVM: s390: add tracepoint in gmap notifier
  - From: Nico Boehr