On Wed, 12 Jul 2023 13:58:49 +0200 Janosch Frank <frankja@xxxxxxxxxxxxx> wrote: > On 7/5/23 13:19, Claudio Imbrenda wrote: > > The index field of the struct page corresponding to a guest ASCE should > > be 0. When replacing the ASCE in s390_replace_asce(), the index of the > > new ASCE should also be set to 0. > > > > Having the wrong index might lead to the wrong addresses being passed > > around when notifying pte invalidations, and eventually to validity > > intercepts (VM crash) if the prefix gets unmapped and the notifier gets > > called with the wrong address. > > > > Signed-off-by: Claudio Imbrenda <imbrenda@xxxxxxxxxxxxx> > > No fixes tag? oops, you're right Fixes: faa2f72cb356 ("KVM: s390: pv: leak the topmost page table when destroy fails") > > Reviewed-by: Janosch Frank <frankja@xxxxxxxxxxxxx> >