Re: [kvm-unit-tests PATCH v10 1/2] s390x: topology: Check the Perform Topology Function

[Pierre Morel <pmorel@xxxxxxxxxxxxx>]

On 6/29/23 10:49, Nico Boehr wrote:
> Quoting Pierre Morel (2023-06-27 10:21:54)
> [...]
> > diff --git a/s390x/topology.c b/s390x/topology.c
> > new file mode 100644
> > index 0000000..7e1bbf9
> > --- /dev/null
> > +++ b/s390x/topology.c
> > @@ -0,0 +1,190 @@
> [...]
> > +static void check_privilege(int fc)
> > +{
> > +       unsigned long rc;
> > +       char buf[20];
> > +
> > +       snprintf(buf, sizeof(buf), "Privileged fc %d", fc);
> > +       report_prefix_push(buf);
> We have report_prefix_pushf (note the f at the end!) for this.
>
> I can fix that up when picking in case there's no new version, though.


ohhh, perfect.

Yes please if you can, do it :)

Thanks

Pierre