On 20.06.23 21:16, Simon Horman wrote: > On Tue, Jun 20, 2023 at 10:34:09AM +0200, Alexandra Winter wrote: >> From: Thorsten Winkler <twinkler@xxxxxxxxxxxxx> >> >> This LWN article explains the rationale for this change >> https: //lwn.net/Articles/69419/ >> Ie. snprintf() returns what *would* be the resulting length, >> while scnprintf() returns the actual length. > Hi Alexandra, > > Although I agree that it's nice to use scnprintf() the justification given > seems a bit odd: it talks of the return value but it is ignored both before > and after this patch. > > Likewise for some of the changes in patch 4/4. You are correct. The main improvement of these patches is to get rid of sprintf. And we decided to use scnprintf everywhere. I'll send a v2 with a slightly updated description. > > Also is it intentional that there is a space in the URL immediately > after 'http:' ? Maybe mangled by something. Not that it really maters > AFAIC. Thanks for spotting this, Simon. Corrected in v2.
