On 6/19/23 03:04, Alexandra Winter wrote: > > > On 16.06.23 10:10, patchwork-bot+netdevbpf@xxxxxxxxxx wrote: >> Hello: >> >> This patch was applied to netdev/net-next.git (main) >> by David S. Miller <davem@xxxxxxxxxxxxx>: >> >> On Thu, 15 Jun 2023 15:21:52 -0700 you wrote: >>> When CONFIG_ETHERNET=m or CONFIG_FDDI=m, lcs.s has build errors or >>> warnings: >>> > > IIUC, CONFIG_ETHERNET is bool. duh, yes. Thanks. > I reproduced this with CONFIG_ETHERNET=n and CONFIG_FDDI=m, > and verified that it does compile with your patch. > > Thank you Randy for correcting this. > >>> ../drivers/s390/net/lcs.c:40:2: error: #error Cannot compile lcs.c without some net devices switched on. >>> 40 | #error Cannot compile lcs.c without some net devices switched on. >>> ../drivers/s390/net/lcs.c: In function 'lcs_startlan_auto': >>> ../drivers/s390/net/lcs.c:1601:13: warning: unused variable 'rc' [-Wunused-variable] >>> 1601 | int rc; >>> >>> [...] >> >> Here is the summary with links: >> - s390/net: lcs: use IS_ENABLED() for kconfig detection >> https://git.kernel.org/netdev/net-next/c/128272336120 >> >> You are awesome, thank you! > -- ~Randy
