> From: Alex Williamson <alex.williamson@xxxxxxxxxx> > Sent: Tuesday, June 13, 2023 10:18 PM > > > > diff --git a/include/linux/vfio.h b/include/linux/vfio.h > > > > index 83cc5dc28b7a..e80a8ac86e46 100644 > > > > --- a/include/linux/vfio.h > > > > +++ b/include/linux/vfio.h > > > > @@ -66,6 +66,7 @@ struct vfio_device { > > > > struct iommufd_device *iommufd_device; > > > > bool iommufd_attached; > > > > #endif > > > > + bool cdev_opened:1; > > > > > > Perhaps a more strongly defined data type here as well and roll > > > iommufd_attached into the same bit field scheme. > > > > Ok, then needs to make iommufd_attached always defined. > > That does not follow. Thanks, Well, I meant the iommufd_attached now is defined only when CONFIG_IOMMUFD is enabled. To toll it with cdev_opened, needs to change this. Regards, Yi Liu