Quoting Claudio Imbrenda (2023-05-16 19:30:18) [...] > > diff --git a/lib/s390x/interrupt.c b/lib/s390x/interrupt.c > > index 2e5309cee40f..82b4259d433c 100644 > > --- a/lib/s390x/interrupt.c > > +++ b/lib/s390x/interrupt.c [...] > > +/** > > + * read_pgm_int_code - Get the program interruption code of the last pgm int > > + * on the current CPU. > > + * > > + * This is similar to clear_pgm_int(), except that it doesn't clear the > > + * interruption information from lowcore. > > + * > > + * Returns 0 when none occured. > > + */ > > +uint16_t read_pgm_int_code(void) > > could this whole function go in the header as static inline? Yes, sure, changed. > > +{ > > + mb(); > > is the mb really needed? No, I don't think so, since this is a function, I'll remove this.