On 06-05-23, 19:16, Baoquan He wrote: > On s390 systems (aka mainframes), it has classic channel devices for > networking and permanent storage that are currently even more common > than PCI devices. Hence it could have a fully functional s390 kernel > with CONFIG_PCI=n, then the relevant iomem mapping functions > [including ioremap(), devm_ioremap(), etc.] are not available. > > Here let QCOM_HIDMA depend on HAS_IOMEM so that it won't be built to > cause below compiling error if PCI is unset. I have 2/2 patch here, where is patch 1 of 2..? > > -------------------------------------------------------- > ld: drivers/dma/qcom/hidma.o: in function `hidma_probe': > hidma.c:(.text+0x4b46): undefined reference to `devm_ioremap_resource' > ld: hidma.c:(.text+0x4b9e): undefined reference to `devm_ioremap_resource' > make[1]: *** [scripts/Makefile.vmlinux:35: vmlinux] Error 1 > make: *** [Makefile:1264: vmlinux] Error 2 > > Signed-off-by: Baoquan He <bhe@xxxxxxxxxx> > Reviewed-by: Niklas Schnelle <schnelle@xxxxxxxxxxxxx> > Cc: Andy Gross <agross@xxxxxxxxxx> > Cc: Bjorn Andersson <andersson@xxxxxxxxxx> > Cc: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> > Cc: Vinod Koul <vkoul@xxxxxxxxxx> > Cc: linux-arm-msm@xxxxxxxxxxxxxxx > Cc: dmaengine@xxxxxxxxxxxxxxx > --- > drivers/dma/qcom/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/dma/qcom/Kconfig b/drivers/dma/qcom/Kconfig > index 3f926a653bd8..ace75d7b835a 100644 > --- a/drivers/dma/qcom/Kconfig > +++ b/drivers/dma/qcom/Kconfig > @@ -45,6 +45,7 @@ config QCOM_HIDMA_MGMT > > config QCOM_HIDMA > tristate "Qualcomm Technologies HIDMA Channel support" > + depends on HAS_IOMEM > select DMA_ENGINE > help > Enable support for the Qualcomm Technologies HIDMA controller. > -- > 2.34.1 -- ~Vinod
