On 2023/4/5 22:48, Wenjia Zhang wrote:
Hi Wen,
Thank you for the new version. The discussion on the open issue is still on-going in our organisation internally. I
appreciate your patience!
One thing I need to mention during testing the loopback device on our platform is that we get crash, because
smc_ism-signal_shutdown() is called by smc_1gr_free_work(), which is called indirectly by smc_conn_free(). Please make
sure that it would go to the path of the loopback device cleanly. Any question and consideration is welcome!
Thanks,
Wenjia
Thank you! Wenjia. Testing on s390 is really helpful.
Since most of the path in smc_ism_signal_shutdown() is inside the preprocessing
macro '#if IS_ENABLED(CONFIG_ISM) ... #endif', so they are not executed in my
test environment, therefore I didn't realized the interface of ops->signal_event
in loopback device and missed the crash.
I will fix this and check for the other parts wrapped by '#if IS_ENABLED(CONFIG_ISM)
... #endif' which I ignored before. Then I will send out a new version.
Thanks,
Wen Gu
