On Wed, Mar 15, 2023 at 01:40:45PM -0700, Jakub Kicinski wrote: > On Wed, 15 Mar 2023 16:27:05 +0800 Tony Lu wrote: > > > You're missing a --- separator here, try to apply this patch with > > > git am :/ > > > > There is another commit ce7ca794712f ("net/smc: fix fallback failed > > while sendmsg with fastopen") that has been merged that also has this > > problem. Maybe we can add some scripts to check this? > > Good idea, checkpatch is probably the right place to complain? Agree with you. > A check along the lines of "if Sign-off-by: has been seen, no > empty lines are allowed until ---"? Yes. > Would you be willing to try to code that up and send it to the > checkpatch maintainer? If they refuse we can create a local > check just for networking in our on scripts. Sure, I will do it. Thanks, Tony Lu