On Wed, Mar 15, 2023 at 12:18:01PM +0000, Liu, Yi L wrote: > > OK. Basically I followed what Jason suggested by having three > > APIs and combined Kevin's inputs about the difference between > > the attach/replace(). I also updated the replace changes, and > > rebased all nesting (infrastructure, VT-d and SMMU): > > https://github.com/nicolinc/iommufd/commits/wip/iommufd_nesting-03142023 > > > > The major three changes for those APIs: > > [1] This adds iommufd_access_attach() in this series: > > "iommufd: Create access in vfio_iommufd_emulated_bind()" > > > > https://github.com/nicolinc/iommufd/commit/34fba7509429380f828fb23dc > > ca5ceaeb40e22b5 > > [2] This adds iommufd_access_detach() in the cdev series: > > "iommufd/device: Add iommufd_access_detach() API" > > > > https://github.com/nicolinc/iommufd/commit/4110522146ca1fc0d5321c04a > > 097e2c9d9e26af4 > > [3] This adds iommufd_access_replace() in the replace series: > > "iommufd: Add iommufd_access_replace() API" > > > > https://github.com/nicolinc/iommufd/commit/36507fa9f0f42cf1a5bebe7c9 > > bc2bf319b7654a8 > > > > Please check if they look okay, so that Yi can integrate them > > accordingly to the emulated/cdev series. > > Thanks. I'll start to integrate after ack from Kevin or Jason. btw. > Below is my latest code (rebased on top of rc-2). 😊 > > https://github.com/yiliu1765/iommufd/tree/wip/vfio_device_cdev_v7_candidate Jason is travelling per his email in the iommufd group. Perhaps Kevin can help us here. After that, we can integrate a version and (if necessary) rework a bit after Jason comes back. Overall I think they are pretty close to what Jason suggested. Thanks Nic
