On Fri, Feb 24, 2023 at 02:21:33AM +0000, Tian, Kevin wrote: > Yi, while you are incorporating this change please also update the > uapi header. Rename 'group_fds[]' to 'fds[]' and add comment to > explain that it could be an array of group fds or a single iommufd. Upon reflection we can probably make it even simpler and just have a 0 length fd array mean to use the iommufd the vfio_device is already associated with And the check for correctness can be simplified to simply see if each vfio_device in the dev_set is attached to the same iommufd ctx pointer instead of searching the xarray. Would need to double check that the locking is OK but seems doable Jason
