On Thu, Feb 16, 2023, at 10:05, Niklas Schnelle wrote: > On Thu, 2023-02-16 at 15:34 +0800, Baoquan He wrote: >> diff --git a/drivers/pcmcia/Kconfig b/drivers/pcmcia/Kconfig >> index 1525023e49b6..7c412bbe8bbe 100644 >> --- a/drivers/pcmcia/Kconfig >> +++ b/drivers/pcmcia/Kconfig >> @@ -20,6 +20,7 @@ if PCCARD >> >> config PCMCIA >> tristate "16-bit PCMCIA support" >> + depends on HAS_IOMEM >> select CRC32 >> default y >> help > > Not sure how many PCMCIA drivers only use I/O memory but not I/O ports > the latter of which are badly stubbed out on s390, though at leat they > compile. I have a series on that part that I intend to send a new > version for soon™. That said yes this does solve the compilation issue > and there could be drivers which rely only on I/O memory and are not > broken in principle. There are no platforms that have I/O ports but don't set HAS_IOMEM, so it doesn't really matter. > Reviewed-by: Niklas Schnelle <schnelle@xxxxxxxxxxxxx> Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
