On Tue, Feb 14, 2023 at 04:42:35PM -0700, Alex Williamson wrote: > A device file opened through a group could be passed through this > interface though, right? Yes, I think so > Do we just chalk that up to user error? Maybe the SPAPR extension > at least needs to be documented as relying on registering groups > rather than devices. The way these APIs work is you have to pass the same FD to all of them. The SPAPR stuff is no different, if you used a cdev with KVM_DEV_VFIO_GROUP_ADD then you have to use the same cdev fd with the SPAPR group_fd. Yi just didn't rename it. It is weird, but logically self consistent, I think. > > I'm still thinking about proposing to just delete all this SPAPR > > stuff. Power still hasn't had the patches applied to make it work > > again so it seems to all be dead. > > There's been some off-list discussion about at least fixing SPAPR > support, but yes, it either needs to get some love or we ought to think > about its future. Thanks, The patches exist, they just need to be applied AFAIK. If the people responsible can't care enough about this to even do that then I find it hard to care at all about the state of SPAPR. Jason
