On Thu, Jan 05, 2023 at 08:03:32PM -0500, Matthew Rosato wrote: > On 1/5/23 7:32 PM, Jason Gunthorpe wrote: > > On Thu, Jan 05, 2023 at 07:16:37PM -0500, Matthew Rosato wrote: > > > >> Yeah, this is also what I was thinking, replace the direct > >> kvm_put_kvm calls with, say, schedule_delayed_work in each driver, > >> where the delayed task just does the kvm_put_kvm (along with a brief > >> comment explaining why we handle the put asynchronously). > > > > Don't put that in every driver, do something like mmput_async() where > > the core code has all of this. > > > > If the core vfio code were to add logic to invoke kvm_put_kvm and > kvm_get_kvm, won't this introduce a vfio dependency on kvm? If I > recall, we have the drivers handling the kvm reference today in > order to avoid that.. Not in vfio, put it in kvm 'kvm_put_async()' Jason
