On Thu, 2022-11-03 at 19:43 -0400, Matthew Rosato wrote: > On 11/3/22 5:56 PM, Alex Williamson wrote: > > On Wed, 2 Nov 2022 16:01:45 +0100 > > Eric Farman <farman@xxxxxxxxxxxxx> wrote: > > > > > Hi all, > > > > > > Here is an update to the vfio-ccw lifecycle changes that have > > > been discussed > > > in various forms over the past year [1][2] or so, and which I > > > dusted off > > > recently. > > > > > > Patches 1-5 rework the behavior of the vfio-ccw driver's private > > > struct. > > > In summary, the mdev pieces are split out of vfio_ccw_private and > > > into a > > > new vfio_ccw_parent struct that will continue to follow today's > > > lifecycle. > > > The remainder (bulk) of the private struct moves to follow the > > > mdev > > > probe/remove pair. There's opportunity for further separation of > > > the > > > things in the private struct, which would simplify some of the > > > vfio-ccw > > > code, but it got too hairy as I started that. Once vfio-ccw is no > > > longer > > > considered unique, those cleanups can happen at our leisure. > > > > > > Patch 6 removes the trickery where vfio-ccw uses vfio_init_device > > > instead of > > > vfio_alloc_device, and thus removes vfio_init_device from the > > > outside world. > > > > > > Patch 7 removes vfio_free_device from vfio-ccw and the other > > > drivers (hello, > > > CC list!), letting it be handled by vfio_device_release directly. > > > > Looks like another spin is pending, but the vfio core and > > collateral > > changes in 6 and 7 look good to me. Would this go in through the > > vfio > > or s390 tree? I'd be happy to merge or provide a branch, depending > > on > > the route. > > > > For 6 & 7: > > Acked-by: Alex Williamson <alex.williamson@xxxxxxxxxx> > > > > Thanks, > > Alex > > LGTM with those few comments addressed -- @Eric please send a v3 and > I think it's ready. Will do that now; thanks Matt. > > I would suggest vfio tree to reduce the chance of conflicts; this > touches various vfio drivers (and main) with the last patches while > the s390 hits are at least all contained to the vfio-ccw driver code. > Agreed. Thanks to you both.
