RE: [PATCH 02/10] vfio: Move vfio_device_assign_container() into vfio_device_first_open()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Jason Gunthorpe <jgg@xxxxxxxxxx>, Alexander Gordeev <agordeev@xxxxxxxxxxxxx>, David Airlie <airlied@xxxxxxxxx>, Tony Krowiak <akrowiak@xxxxxxxxxxxxx>, Alex Williamson <alex.williamson@xxxxxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxxxxx>, Cornelia Huck <cohuck@xxxxxxxxxx>, Daniel Vetter <daniel@xxxxxxxx>, Diana Craciun <diana.craciun@xxxxxxxxxxx>, "dri-devel@xxxxxxxxxxxxxxxxxxxxx" <dri-devel@xxxxxxxxxxxxxxxxxxxxx>, Eric Auger <eric.auger@xxxxxxxxxx>, "Eric Farman" <farman@xxxxxxxxxxxxx>, Harald Freudenberger <freude@xxxxxxxxxxxxx>, Vasily Gorbik <gor@xxxxxxxxxxxxx>, Heiko Carstens <hca@xxxxxxxxxxxxx>, "intel-gfx@xxxxxxxxxxxxxxxxxxxxx" <intel-gfx@xxxxxxxxxxxxxxxxxxxxx>, "intel-gvt-dev@xxxxxxxxxxxxxxxxxxxxx" <intel-gvt-dev@xxxxxxxxxxxxxxxxxxxxx>, "iommu@xxxxxxxxxxxxxxx" <iommu@xxxxxxxxxxxxxxx>, Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>, Jason Herne <jjherne@xxxxxxxxxxxxx>, "Joonas Lahtinen" <joonas.lahtinen@xxxxxxxxxxxxxxx>, Joerg Roedel <joro@xxxxxxxxxx>, "kvm@xxxxxxxxxxxxxxx" <kvm@xxxxxxxxxxxxxxx>, "linux-s390@xxxxxxxxxxxxxxx" <linux-s390@xxxxxxxxxxxxxxx>, Longfang Liu <liulongfang@xxxxxxxxxx>, "Matthew Rosato" <mjrosato@xxxxxxxxxxxxx>, Peter Oberparleiter <oberpar@xxxxxxxxxxxxx>, Halil Pasic <pasic@xxxxxxxxxxxxx>, Robin Murphy <robin.murphy@xxxxxxx>, "Vivi, Rodrigo" <rodrigo.vivi@xxxxxxxxx>, "Shameer Kolothum" <shameerali.kolothum.thodi@xxxxxxxxxx>, Sven Schnelle <svens@xxxxxxxxxxxxx>, Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx>, Vineeth Vijayan <vneethv@xxxxxxxxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Yishai Hadas <yishaih@xxxxxxxxxx>, Zhenyu Wang <zhenyuw@xxxxxxxxxxxxxxx>, "Wang, Zhi A" <zhi.a.wang@xxxxxxxxx>
Subject: RE: [PATCH 02/10] vfio: Move vfio_device_assign_container() into vfio_device_first_open()
From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
Date: Tue, 1 Nov 2022 07:38:47 +0000
Accept-language: en-US
Cc: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>, Nicolin Chen <nicolinc@xxxxxxxxxx>, "Liu, Yi L" <yi.l.liu@xxxxxxxxx>
In-reply-to: <2-v1-4991695894d8+211-vfio_iommufd_jgg@nvidia.com>
References: <0-v1-4991695894d8+211-vfio_iommufd_jgg@nvidia.com> <2-v1-4991695894d8+211-vfio_iommufd_jgg@nvidia.com>
Thread-index: AQHY6J4OZI6/AUkjGE6GW5b3OnsydK4puA6Q
Thread-topic: [PATCH 02/10] vfio: Move vfio_device_assign_container() into vfio_device_first_open()

> From: Jason Gunthorpe <jgg@xxxxxxxxxx>
> Sent: Wednesday, October 26, 2022 2:17 AM
> 
> +err_container:
> +	vfio_device_unassign_container(device);
>  err_module_put:
>  	device->kvm = NULL;

err_module_put should be moved after nullifying device->kvm.

otherwise it looks good to me:

Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Follow-Ups:
- Re: [PATCH 02/10] vfio: Move vfio_device_assign_container() into vfio_device_first_open()
  - From: Jason Gunthorpe

References:
- [PATCH 00/10] Connect VFIO to IOMMUFD
  - From: Jason Gunthorpe
- [PATCH 02/10] vfio: Move vfio_device_assign_container() into vfio_device_first_open()
  - From: Jason Gunthorpe

Prev by Date: RE: [PATCH 01/10] vfio: Move vfio_device driver open/close code to a function
Next by Date: RE: [PATCH 03/10] vfio: Rename vfio_device_assign/unassign_container()
Previous by thread: [PATCH 02/10] vfio: Move vfio_device_assign_container() into vfio_device_first_open()
Next by thread: Re: [PATCH 02/10] vfio: Move vfio_device_assign_container() into vfio_device_first_open()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite Info] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Samba] [Linux Media] [Device Mapper]