> From: Jason Gunthorpe <jgg@xxxxxxxxxx> > Sent: Wednesday, August 17, 2022 11:30 PM > > +/* Will be exported for vfio pci drivers usage */ > int vfio_pci_register_dev_region(struct vfio_pci_core_device *vdev, > unsigned int type, unsigned int subtype, > const struct vfio_pci_regops *ops, > size_t size, u32 flags, void *data); NIT. This wants to follow the convention of other exported symbols in following line i.e. having 'vfio_pci_core_' as the prefix. Apart from that: Reviewed-by: <kevin.tian@xxxxxxxxx>