Hi Mark, On Tue, Jul 19, 2022 at 2:42 PM Mark Rutland <mark.rutland@xxxxxxx> wrote: > > -static inline bool __must_check arch_get_random_long(unsigned long *v) > > +static inline size_t __must_check arch_get_random_words(unsigned long *v, size_t words) > > As others have suggested, could we please s/words/longs/? That's a smaller > change from the existing name, and avoids amibugity were "word" has an > architecture-specific meaning. e.g. the ARM ARM (ARM DDI 0487G.b) defines: At first I had thought, "erm, I like 'words'" but decided to wait it out, and now it's two people with the same probably good objection to 'words', so I'll send a v+1 with 'longs' instead. Thanks for your feedback. Patch incoming. > FWIW, other than the naming nits, the arm64 bits look fine to me. Oh good. Can you send an Acked-by for v+1? Coming up shortly. Jason
