Quoting Claudio Imbrenda (2022-07-05 10:20:11) Sorry Claudio, missed your mail as well... > > diff --git a/lib/s390x/asm/time.h b/lib/s390x/asm/time.h > > index 7652a151e87a..9ae364afb8a3 100644 > > --- a/lib/s390x/asm/time.h > > +++ b/lib/s390x/asm/time.h > > @@ -11,9 +11,13 @@ [...] > > +#define TIMING_S390_SHIFT_US (63 - 51) > > I would call it S390_CLOCK_SHIFT_US Will do. [...] > > +static inline void cpu_timer_set(int64_t timeout_ms) > > I would call the function cpu_timer_set_ms > > so that it's clear what unit goes in, and it makes things easier if in > the future someone needs a _us version Makes sense, that's also how the other functions are, so it is more consistent.
