Re: [PATCH] trace-cmd: fix writing of uncompressed size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Tzvetomir Stoyanov <tz.stoyanov@xxxxxxxxx> writes:

>> I see that 'handle->pointer' is unsigned long, which is 8 bytes on
>> s390. But it is converted as 4 byte int. That would work on LE
>> platforms, but not on BE.
>
> Yes, that looks like a problem. I think the best fix is to change
> 'handle->pointer' to unsigned int, can you test that on s390? There is
> no need of 8 bytes for that size, unsigned int should be OK. This is
> the size of one data chunk, it should not exceed 4G. Do you want to
> submit such a fix, if it works on s390?

Yes, converting it to unsigned int works. I'll submit a fix.

Thanks!
Sven



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Kernel Development]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Info]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Linux Media]     [Device Mapper]

  Powered by Linux